Skip to content

Fix obb-collider to work on text-geometry#5833

Merged
dmarcos merged 2 commits into
aframevr:masterfrom
vincentfretin:fix-obb-collider-text-geometry
Jun 15, 2026
Merged

Fix obb-collider to work on text-geometry#5833
dmarcos merged 2 commits into
aframevr:masterfrom
vincentfretin:fix-obb-collider-text-geometry

Conversation

@vincentfretin

Copy link
Copy Markdown
Contributor

Description:

Fix obb-collider to work on text-geometry with obb-collider="centerModel: true"

Changes proposed:

  • Don't assume mesh comes from glf-model, use generic el.getObject3D('mesh');
  • Call if (this.data.centerModel) { this.centerModel(); } before this.updateCollider(); in init, same as in onModelLoaded, text-geometry doesn't have a model-loaded event so it didn't center the mesh

@dmarcos

dmarcos commented Jun 15, 2026

Copy link
Copy Markdown
Member

thanks

@dmarcos dmarcos merged commit 07ffc8b into aframevr:master Jun 15, 2026
1 check passed
@vincentfretin vincentfretin deleted the fix-obb-collider-text-geometry branch June 15, 2026 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants