Conversation
rofe
commented
Jun 17, 2026
| push(item) { this.items.push(item); } | ||
| push(item) { | ||
| this.items.push(item); | ||
| return this.callback ? this.callback(item) : undefined; |
Contributor
Author
There was a problem hiding this comment.
This fixture Queue was previously a no-op — push() enqueued items but never invoked a callback. The real nx Queue runs the callback per item (new Queue(callback, …)), which is how handleConfirmDelete drives its per-item unpublish logic.
Without this change the new test can't reach the .html-stripping code path being fixed here (the callback never fires). I kept the stub minimal — just callback invocation — and left out the real Queue's concurrency/throttle/on-complete behavior since the test doesn't need it.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Use the list item's ext field instead of a path string check, and cover the non-HTML pass-through case. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
chrischrischris
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1007
Test URL: https://unpubext--da-live--adobe.aem.live/
🤖 Generated with Claude Code