Clarify InputBinding.Matches mask semantics#2426
Open
AswinRajGopal wants to merge 3 commits into
Open
Conversation
![u-pr[bot]](https://avatars.githubusercontent.com/in/1201017?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
The changes are clean and well-structured, with only a minor XML documentation warning worth addressing to ensure proper reference resolution.
Additional observations
Packages/com.unity.inputsystem/InputSystem/Runtime/Actions/InputBinding.cs:786(low) — In C# XML documentation, referencing overloaded operators typically requires a space between theoperatorkeyword and the operator symbol itself. Consider changing<see cref="operator=="/>to<see cref="operator =="/>(or fully specifying it as<see cref="operator ==(InputBinding, InputBinding)"/>) to ensure documentation generators (such as DocFX) resolve the reference correctly and to avoid potential CS1574 compiler warnings.
🤖 Helpful? 👍/👎
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## develop #2426 +/- ##
===========================================
+ Coverage 78.13% 78.89% +0.76%
===========================================
Files 483 762 +279
Lines 98770 139274 +40504
===========================================
+ Hits 77169 109882 +32713
- Misses 21601 29392 +7791 Flags with carried forward coverage won't be shown. Click here to find out more.
|
suearkinunity
approved these changes
Jun 3, 2026
Collaborator
suearkinunity
left a comment
suearkinunity
left a comment
There was a problem hiding this comment.
Two small suggestions - we use "don't" instead of "does not".
…utBinding.cs Co-authored-by: Sue Arkin <85237015+suearkinunity@users.noreply.github.com>
…utBinding.cs Co-authored-by: Sue Arkin <85237015+suearkinunity@users.noreply.github.com>
ritamerkl
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Clarifies the XML documentation for
InputBinding.Matchesto state that it performs mask/filter matching, not equality comparison.The updated docs call out that a binding may not match itself when one of its mask fields, such as
groups, contains a value that does not match as a filter. The docs now alsopoint users toEquals(InputBinding)/==for binding equivalence checks.Testing status & QA
Documentation-only change. No tests run.
Overall Product Risks
Please rate the potential complexity and halo effect from low to high for the reviewers. Note down potential risks to specific Editor branches if any.
Comments to reviewers
Please describe any additional information such as what to focus on, or historical info for the reviewers.
Checklist
Before review:
Changed,Fixed,Addedsections.Area_CanDoX,Area_CanDoX_EvenIfYIsTheCase,Area_WhenIDoX_AndYHappens_ThisIsTheResult.During merge:
NEW: ___.FIX: ___.DOCS: ___.CHANGE: ___.RELEASE: 1.1.0-preview.3.