Skip to content

fix(ui5-toolbar): fix visual findings in the toolbar#13653

Merged
PetyaMarkovaBogdanova merged 2 commits into
mainfrom
fix-toolbar-visual-findings
Jun 11, 2026
Merged

fix(ui5-toolbar): fix visual findings in the toolbar#13653
PetyaMarkovaBogdanova merged 2 commits into
mainfrom
fix-toolbar-visual-findings

Conversation

@PetyaMarkovaBogdanova

@PetyaMarkovaBogdanova PetyaMarkovaBogdanova commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Three CSS bugs in ui5-toolbar identified via visual spec analysis against the AI test review.

Changes

  • Toolbar.css — Fix swapped variable names in padding shorthand. padding: 0 right 0 left was referencing --_ui5-toolbar-padding-left for the right slot and vice versa:

    /* Before (wrong) */
    padding: 0 var(--_ui5-toolbar-padding-left) 0 var(--_ui5-toolbar-padding-right);
    
    /* After (correct) */
    padding: 0 var(--_ui5-toolbar-padding-right) 0 var(--_ui5-toolbar-padding-left);
  • Toolbar-parameters.css — Bump --_ui5-toolbar-item-margin-right from 0.25rem0.5rem to match the visual spec.

  • ToolbarItem.css — Remove display: inline-block from :host. This was preventing flex-based responsive sizing for slotted content (e.g. ui5-breadcrumbs) because inline-block constrains the host to shrink-to-content width rather than participating correctly in the toolbar's flex layout.
    Fixes: Toolbar: some adjustments needed #13508

@sap-ui5-webcomponents-release

sap-ui5-webcomponents-release Bot commented Jun 5, 2026

Copy link
Copy Markdown

@PetyaMarkovaBogdanova PetyaMarkovaBogdanova merged commit b012844 into main Jun 11, 2026
19 of 20 checks passed
@PetyaMarkovaBogdanova PetyaMarkovaBogdanova deleted the fix-toolbar-visual-findings branch June 11, 2026 10:44
@sap-ui5-webcomponents-release

Copy link
Copy Markdown

🧹 Preview deployment cleaned up: https://pr-13653--ui5-webcomponents.netlify.app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Toolbar: some adjustments needed

2 participants