Skip to content

feat(ui5-timeline): introduce header and info-bar slots#13548

Merged
hinzzx merged 9 commits into
mainfrom
tl-header-poc
Jun 9, 2026
Merged

feat(ui5-timeline): introduce header and info-bar slots#13548
hinzzx merged 9 commits into
mainfrom
tl-header-poc

Conversation

@hinzzx

@hinzzx hinzzx commented May 19, 2026

Copy link
Copy Markdown
Contributor

High-level Architecture additions

  • Added a header slot for a controls bar above the items.
  • Added an infoBar slot for a status bar below the controls, reflecting the active state.
  • Added a stickyHeader boolean that pins the header bar to the top while scrolling.

Overview

The Timeline had no built-in way to place controls (search, filter, sort) above its items. Applications had to build custom layouts around it, leading to inconsistent patterns and no standardized sticky behavior.

What we did

Added two optional slots above the items area:

  • header — for controls (search field, sort/filter buttons). Typically holds a ui5-toolbar.
  • infoBar — for status display (active filter tokens, item count). Typically holds a ui5-bar.

Plus:

Property What it does
stickyHeader Pins both bars at the top while scrolling

Key points

  • The Timeline does not search, sort, or filter — apps stay in full control.
  • Sticky behavior is CSS-only — no JS measurement needed.
  • Fully backwards compatible — Timelines without these slots work as before.

Test plan

  • yarn test:cypress:single cypress/specs/Timeline.cy.tsx in packages/fiori
  • Website samples render correctly (cd packages/website && yarn start)
  • Search, filter, sort, and token removal work interactively
  • Sticky behavior works when scrolling

@ui5-webcomponents-bot

ui5-webcomponents-bot commented May 19, 2026

Copy link
Copy Markdown
Collaborator

🧹 Preview deployment cleaned up: https://pr-13548--ui5-webcomponents.netlify.app

@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview May 19, 2026 12:30 Inactive
@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview May 21, 2026 08:10 Inactive
@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview May 29, 2026 11:54 Inactive
@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview May 29, 2026 12:04 Inactive
@hinzzx hinzzx changed the title feat(ui5-timeline): [PoC]introduce header and info-bar slots feat(ui5-timeline): introduce header and info-bar slots May 29, 2026
@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview May 29, 2026 12:16 Inactive
@GDamyanov GDamyanov self-requested a review June 2, 2026 08:10
Comment thread packages/fiori/src/themes/Timeline.css Outdated
Comment thread packages/fiori/src/Timeline.ts
Comment thread packages/website/docs/_samples/fiori/Timeline/StickyInPage/main.js Outdated
Comment thread packages/website/docs/_samples/fiori/Timeline/StickyInPage/sample.html Outdated
@hinzzx hinzzx temporarily deployed to netlify-preview June 3, 2026 12:32 — with GitHub Actions Inactive
GDamyanov
GDamyanov previously approved these changes Jun 5, 2026
@hinzzx hinzzx temporarily deployed to netlify-preview June 9, 2026 06:41 — with GitHub Actions Inactive
@GDamyanov GDamyanov self-requested a review June 9, 2026 06:47
@hinzzx hinzzx merged commit 7b71a03 into main Jun 9, 2026
20 of 21 checks passed
@hinzzx hinzzx deleted the tl-header-poc branch June 9, 2026 07:11
@hinzzx hinzzx temporarily deployed to netlify-preview June 9, 2026 07:11 — with GitHub Actions Inactive
@DMihaylova DMihaylova mentioned this pull request Jun 10, 2026
1 task
@sap-ui5-webcomponents-release

Copy link
Copy Markdown

🎉 This PR is included in version v2.24.0-rc.0 🎉

The release is available on v2.24.0-rc.0

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants