Skip to content

fix: rename directories originally missed#2364

Merged
rsynek merged 1 commit into
TimefoldAI:mainfrom
rsynek:fix/missing-rename
Jun 12, 2026
Merged

fix: rename directories originally missed#2364
rsynek merged 1 commit into
TimefoldAI:mainfrom
rsynek:fix/missing-rename

Conversation

@rsynek

@rsynek rsynek commented Jun 12, 2026

Copy link
Copy Markdown
Collaborator

Fixing the release CI,

@rsynek rsynek requested a review from triceo as a code owner June 12, 2026 08:57
Copilot AI review requested due to automatic review settings June 12, 2026 08:57
Comment thread .github/scripts/change_versions.sh

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the service module’s Maven structure to reflect the renamed facade/service* and service-defaults directories, aligning parent/module references and the release version-bump script to the new paths to restore release CI behavior.

Changes:

  • Update module listings and parent relativePath references from the old facade/model* locations to facade/service*.
  • Add new service facade aggregator POMs (service, service-with-maps) and the new service-parent POM.
  • Introduce service-defaults module with a default application.properties, and update the release version script to edit the new parent POM.

Reviewed changes

Copilot reviewed 3 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
service/test-model/pom.xml Updates parent relativePath to the renamed facade/service-parent.
service/service-defaults/src/main/resources/application.properties Adds default configuration properties intended to be imported by models.
service/service-defaults/pom.xml Adds the Maven module definition for timefold-solver-service-defaults.
service/pom.xml Switches module declarations from facade/model*/model-defaults to facade/service*/service-defaults.
service/facade/service/pom.xml Adds dependency-aggregator facade module for “service” (no maps).
service/facade/service-with-maps/pom.xml Adds dependency-aggregator facade module for “service with maps”.
service/facade/service-parent/pom.xml Adds the renamed parent POM for model/service builds and related build/deploy profiles.
.github/scripts/change_versions.sh Updates the version bump script to target the renamed service/facade/service-parent/pom.xml.

@sonarqubecloud

Copy link
Copy Markdown

@rsynek rsynek merged commit 9bc0b72 into TimefoldAI:main Jun 12, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants