fix: rename directories originally missed#2364
Merged
Merged
Conversation
rsynek
commented
Jun 12, 2026
triceo
approved these changes
Jun 12, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the service module’s Maven structure to reflect the renamed facade/service* and service-defaults directories, aligning parent/module references and the release version-bump script to the new paths to restore release CI behavior.
Changes:
- Update module listings and parent
relativePathreferences from the oldfacade/model*locations tofacade/service*. - Add new service facade aggregator POMs (
service,service-with-maps) and the newservice-parentPOM. - Introduce
service-defaultsmodule with a defaultapplication.properties, and update the release version script to edit the new parent POM.
Reviewed changes
Copilot reviewed 3 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
service/test-model/pom.xml |
Updates parent relativePath to the renamed facade/service-parent. |
service/service-defaults/src/main/resources/application.properties |
Adds default configuration properties intended to be imported by models. |
service/service-defaults/pom.xml |
Adds the Maven module definition for timefold-solver-service-defaults. |
service/pom.xml |
Switches module declarations from facade/model*/model-defaults to facade/service*/service-defaults. |
service/facade/service/pom.xml |
Adds dependency-aggregator facade module for “service” (no maps). |
service/facade/service-with-maps/pom.xml |
Adds dependency-aggregator facade module for “service with maps”. |
service/facade/service-parent/pom.xml |
Adds the renamed parent POM for model/service builds and related build/deploy profiles. |
.github/scripts/change_versions.sh |
Updates the version bump script to target the renamed service/facade/service-parent/pom.xml. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Fixing the release CI,