Remove abandoned intent-library bin, harden integration tests, fix lint

.changeset/fruity-toys-win.md

@@ -0,0 +1,5 @@
+---
+'@tanstack/intent': patch
+---
+
+Remove the abandoned `intent-library` bin and its `./intent-library` export. The legacy library-bin discovery model was replaced by the keyword-based model; anything invoking `intent-library` directly must move to the normal `intent` discovery flow (no compatibility shim).

knip.json

@@ -7,14 +7,7 @@
       "entry": ["scripts/*.ts"]
     },
     "packages/intent": {
-      "entry": [
-        "src/index.ts",
-        "src/cli.ts",
-        "src/core.ts",
-        "src/setup.ts",
-        "src/intent-library.ts",
-        "src/library-scanner.ts"
-      ],
+      "entry": ["src/index.ts", "src/cli.ts", "src/core.ts", "src/setup.ts"],
       "ignore": ["meta/**"],
       "ignoreDependencies": ["verdaccio", "@verdaccio/node-api"]
     }

nx.json

@@ -31,6 +31,11 @@
       "inputs": ["default", "^production"],
       "outputs": ["{projectRoot}/coverage"]
     },
+    "test:integration": {
+      "cache": true,
+      "dependsOn": ["build", "^build"],
+      "inputs": ["default", "^production"]
+    },
     "test:eslint": {
       "cache": true,
       "dependsOn": ["^build"],

package.json

@@ -26,14 +26,14 @@
     "lint:fix": "nx affected --target=lint:fix --exclude=examples/**",
     "lint:fix:all": "nx run-many --targets=lint --fix",
     "test": "pnpm run test:ci",
-    "test:ci": "tsc --noEmit && nx run-many --targets=test:eslint,test:sherif,test:knip,test:docs,test:lib,test:types,build",
+    "test:ci": "tsc --noEmit && nx run-many --targets=test:eslint,test:sherif,test:knip,test:docs,test:lib,test:integration,test:types,build",
     "generate-docs": "node scripts/generate-docs.ts",
     "test:docs": "node scripts/verify-links.ts",
     "test:eslint": "nx affected --target=test:eslint --exclude=examples/**",
     "test:knip": "knip",
     "test:lib": "nx affected --targets=test:lib --exclude=examples/**",
     "test:lib:dev": "pnpm test:lib && nx watch --all -- pnpm test:lib",
-    "test:pr": "tsc --noEmit && nx affected --targets=test:eslint,test:sherif,test:knip,test:docs,test:lib,test:types,build",
+    "test:pr": "tsc --noEmit && nx affected --targets=test:eslint,test:sherif,test:knip,test:docs,test:lib,test:integration,test:types,build",
     "test:sherif": "sherif",
     "test:types": "nx affected --targets=test:types --exclude=examples/**",
     "watch": "pnpm run build:all && nx watch --all -- pnpm run build:all"

packages/intent/package.json

@@ -13,18 +13,13 @@
       "import": "./dist/index.mjs",
       "types": "./dist/index.d.mts"
     },
-    "./intent-library": {
-      "import": "./dist/intent-library.mjs",
-      "types": "./dist/intent-library.d.mts"
-    },
     "./core": {
       "import": "./dist/core.mjs",
       "types": "./dist/core.d.mts"
     }
   },
   "bin": {
-    "intent": "dist/cli.mjs",
-    "intent-library": "dist/intent-library.mjs"
+    "intent": "dist/cli.mjs"
   },
   "files": [
     "dist",
@@ -44,7 +39,7 @@
   },
   "scripts": {
     "prepack": "npm run build",
-    "build": "tsdown src/index.ts src/cli.ts src/setup.ts src/intent-library.ts src/library-scanner.ts src/core.ts --format esm --dts",
+    "build": "tsdown src/index.ts src/cli.ts src/setup.ts src/core.ts --format esm --dts",
     "test:smoke": "pnpm run build && node dist/cli.mjs --help > /dev/null && node dist/cli.mjs load --help > /dev/null",
     "test:lib": "vitest run --exclude 'tests/integration/**'",
     "test:integration": "vitest run tests/integration/",

packages/intent/src/cli.ts

@@ -247,14 +247,22 @@ export async function main(argv: Array<string> = process.argv.slice(2)) {
   }
 }
 
-let isMain = false
-try {
-  isMain =
-    process.argv[1] !== undefined &&
-    fileURLToPath(import.meta.url) === realpathSync(process.argv[1])
-} catch {}
+export function isMainModule(
+  metaUrl: string,
+  argvPath: string | undefined,
+  realpath: (path: string) => string = realpathSync,
+): boolean {
+  if (argvPath === undefined) {
+    return false
+  }
+  try {
+    return fileURLToPath(metaUrl) === realpath(argvPath)
+  } catch {
+    return false
+  }
+}
 
-if (isMain) {
+if (isMainModule(import.meta.url, process.argv[1])) {
   const exitCode = await main()
   process.exit(exitCode)
 }

packages/intent/src/commands/list.ts

@@ -2,10 +2,10 @@ import {
   coreOptionsFromGlobalFlags,
   printDebugInfo,
   printWarnings,
-  type GlobalScanFlags,
 } from '../cli-support.js'
 import { formatIntentCommand } from '../command-runner.js'
 import { listIntentSkills } from '../core.js'
+import type { GlobalScanFlags } from '../cli-support.js'
 import type {
   IntentPackageSummary,
   IntentSkillList,

packages/intent/src/commands/validate.ts

@@ -2,11 +2,9 @@ import { appendFileSync, existsSync, readFileSync } from 'node:fs'
 import { basename, dirname, join, relative, resolve, sep } from 'node:path'
 import { fail, isCliFailure } from '../cli-error.js'
 import { printWarnings } from '../cli-support.js'
-import {
-  type ProjectContext,
-  resolveProjectContext,
-} from '../core/project-context.js'
+import { resolveProjectContext } from '../core/project-context.js'
 import { findWorkspacePackages } from '../workspace-patterns.js'
+import type { ProjectContext } from '../core/project-context.js'
 
 interface ValidationError {
   file: string

packages/intent/src/core.ts

@@ -6,25 +6,23 @@ import {
   isPackageExcluded,
   warningMentionsPackage,
 } from './core/excludes.js'
-import { createIntentFsCache, type IntentFsCache } from './fs-cache.js'
+import { createIntentFsCache } from './fs-cache.js'
 import { rewriteLoadedSkillMarkdownDestinations } from './core/markdown.js'
 import { resolveSkillUseFastPath } from './core/load-resolution.js'
 import { resolveProjectContext } from './core/project-context.js'
-import {
-  ResolveSkillUseError,
-  resolveSkillUse,
-  type ResolveSkillResult,
-} from './resolver.js'
+import { ResolveSkillUseError, resolveSkillUse } from './resolver.js'
 import { formatSkillUse, parseSkillUse } from './skill-use.js'
 import { scanForIntents } from './scanner.js'
+import type { ResolveSkillResult } from './resolver.js'
+import type { IntentFsCache } from './fs-cache.js'
 import type { ScanOptions, ScanScope } from './types.js'
 import type {
   IntentCoreErrorCode,
   IntentCoreOptions,
   IntentSkillList,
   IntentSkillSummary,
-  LoadedIntentSkillDebug,
   LoadedIntentSkill,
+  LoadedIntentSkillDebug,
   ResolvedIntentSkill,
 } from './core/types.js'
 

packages/intent/src/core/excludes.ts

@@ -1,9 +1,7 @@
 import { dirname, isAbsolute, relative, resolve } from 'node:path'
-import {
-  resolveProjectContext,
-  type ProjectContext,
-} from './project-context.js'
+import { resolveProjectContext } from './project-context.js'
 import { readPackageJson } from './package-json.js'
+import type { ProjectContext } from './project-context.js'
 import type { IntentCoreOptions } from './types.js'
 
 const MAX_EXCLUDE_PATTERN_LENGTH = 200
@@ -117,12 +115,9 @@ export function warningMentionsPackage(
   warning: string,
   packageName: string,
 ): boolean {
-  let fromIndex = 0
-
-  while (true) {
-    const idx = warning.indexOf(packageName, fromIndex)
-    if (idx === -1) return false
+  let idx = warning.indexOf(packageName)
 
+  while (idx !== -1) {
     const before = warning[idx - 1]
     const after = warning[idx + packageName.length]
     if (
@@ -132,6 +127,8 @@ export function warningMentionsPackage(
       return true
     }
 
-    fromIndex = idx + packageName.length
+    idx = warning.indexOf(packageName, idx + packageName.length)
   }
+
+  return false
 }

packages/intent/src/core/load-resolution.ts

@@ -1,15 +1,15 @@
 import { existsSync } from 'node:fs'
 import { dirname, join, resolve } from 'node:path'
-import { createIntentFsCache, type IntentFsCache } from '../fs-cache.js'
-import { resolveSkillEntry, type ResolveSkillResult } from '../resolver.js'
+import { createIntentFsCache } from '../fs-cache.js'
+import { resolveSkillEntry } from '../resolver.js'
 import { scanIntentPackageAtRoot } from '../scanner.js'
 import { findWorkspacePackages } from '../workspace-patterns.js'
 import { getDeps, resolveDepDir } from '../utils.js'
 import { warningMentionsPackage } from './excludes.js'
-import {
-  resolveProjectContext,
-  type ProjectContext,
-} from './project-context.js'
+import { resolveProjectContext } from './project-context.js'
+import type { ResolveSkillResult } from '../resolver.js'
+import type { IntentFsCache } from '../fs-cache.js'
+import type { ProjectContext } from './project-context.js'
 import type { SkillUse } from '../skill-use.js'
 import type { IntentCoreOptions } from './types.js'
 
@@ -70,15 +70,17 @@ function findVisibleDependencyDir(
   fromDir: string,
 ): string | null {
   let dir = fromDir
+  let prev: string | undefined
 
-  while (true) {
+  while (dir !== prev) {
     const candidate = join(dir, 'node_modules', packageName)
     if (existsSync(join(candidate, 'package.json'))) return candidate
 
-    const next = dirname(dir)
-    if (next === dir) return null
-    dir = next
+    prev = dir
+    dir = dirname(dir)
   }
+
+  return null
 }
 
 function resolveDependencyPackageDir(
@@ -134,7 +136,7 @@ function getDirectLoadFastPathCandidateDirs(
     seen,
     resolveDependencyPackageDir(
       packageName,
-      context.packageRoot ?? context.workspaceRoot ?? cwd,
+      context.packageRoot ?? context.workspaceRoot,
     ),
   )
 

packages/intent/src/core/project-context.ts

@@ -54,19 +54,18 @@ export function resolveProjectContext({
 
 function findOwningPackageRoot(startPath: string): string | null {
   let dir = toSearchDir(startPath)
+  let prev: string | undefined
 
-  while (true) {
+  while (dir !== prev) {
     if (existsSync(join(dir, 'package.json'))) {
       return dir
     }
 
-    const next = dirname(dir)
-    if (next === dir) {
-      return null
-    }
-
-    dir = next
+    prev = dir
+    dir = dirname(dir)
   }
+
+  return null
 }
 
 function toSearchDir(path: string): string {