fix: keep sidebar filter when opening a table from the filtered list

[mvanhorn]

Summary

In the tables sidebar, typing a filter and then double-clicking a table to open it cleared the active filter text. The table opened but the filter was wiped.

Root cause is in SidebarContainerViewController. The NSSearchFieldDelegate.searchFieldDidEndSearching(_:) callback unconditionally wrote "" back to the persisted search text. When a table is opened, focus leaves the search field, AppKit fires searchFieldDidEndSearching, and the filter was cleared even though the field still held text.

The fix guards that callback so it only clears the persisted text when the field's stringValue is actually empty (the cancel/clear path leaves an empty value). The live-typing path (controlTextDidChange) is untouched, so typing and clearing via the cancel button still work, and tab scoping between the tables and favorites filters is preserved.

Why this matters

The maintainer confirmed in #1690 that the filter pane is scoped per table tab and is expected to persist. Prefix filtering (for example dp_) should survive opening a table; clearing it on every open made the feature unusable for its main purpose.

Testing

• swiftlint lint --strict passes on the touched files.
• Added TableProTests/Views/SidebarSearchPersistenceTests.swift covering the decision: keep the filter when the field still has text, clear it when the field is empty.
• The clear decision is extracted into a pure nonisolated helper (shouldClearOnEndSearching) so it is unit-testable without standing up AppKit.

Fixes #1690

[chatgpt-codex-connector]

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

[github-actions]

All contributors have signed the CLA ✍️ ✅
_{Posted by the CLA Assistant Lite bot.}

[mvanhorn]

I have read the CLA Document and I hereby sign the CLA.

[datlechin]

Hi @mvanhorn, could you please describe more detail on the behavior both prior to and following this adjustment?

[mvanhorn]

The failing macOS App Tests check isn't from this PR. The test target fails to build on EtcdQueryBuilderTests.swift — #expect(parsed?.filterType == .none) is ambiguous between Optional.none and EtcdFilterType.none under the current Xcode/Swift toolchain, so the whole test target won't compile and none of the tests actually run. This PR only touches SidebarContainerViewController.swift and SidebarSearchPersistenceTests.swift — nothing in the Etcd plugin.

Happy to open a separate PR disambiguating those comparisons (e.g. == EtcdFilterType.none) to get the test target building again, if that's useful. (Side note: the cla check shows red, but the CLA Assistant bot already posted that all contributors have signed.)