fix(editor): capture quoted identifiers in qualified table references#1586
Open
xantiagoma wants to merge 1 commit into
Open
fix(editor): capture quoted identifiers in qualified table references#1586xantiagoma wants to merge 1 commit into
xantiagoma wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
5 tasks
Contributor
Author
|
The failing check is unrelated to this PR: the SQL Context Analyzer suite (which this PR fixes) now passes here. The remaining failure is the ExecuteQueryTool suite, which has been failing identically on every main run since ad82403 (fix(editor): make statement splitting dollar-quote aware for PostgreSQL). Same two issues both there and here: First failing main run with the same errors: https://github.com/TableProApp/TablePro/actions/runs/26887465313 Happy to look into that one separately if useful. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the
SQL Context Analyzerfailure currently red onmain("Strips quoting from the captured schema segment", added in the #1581 squash).The table-reference regexes captured names with
([\w.]+), which cannot cross a quoted segment —FROM "sales".orderscaptured onlysales, so the schema was lost and the test failed. The capture class now includes quote characters, and both the parsed table name and the schema segment strip`,", and':Testing
SQLContextAnalyzerTests(including the four schema-segment tests) andSQLContextAnalyzerCaseInsensitiveTestspass locallyswiftlint lint --strictcleanRelated: #1581, unblocks CI for #1580
🤖 Generated with Claude Code