fix(inspector): prevent window overflow on inspector pane toggle by J2TeamNNL · Pull Request #1463 · TableProApp/TablePro

J2TeamNNL · 2026-05-28T13:35:36Z

Summary

Inspector pane toggle no longer causes content overflow in narrow windows
recomputeWindowMinimumSize now runs in splitViewDidResizeSubviews so manual divider drags also update the floor
Base content min size is re-derived on every call instead of being captured once at startup
hideInspector pre-narrows the window minimum before animation starts, matching the pre-widening pattern in showInspector
Added test covering the case where detail + inspector sum exceeds the 720pt base floor

Test plan

Open connection, resize window to ~720pt, toggle inspector on → window grows to fit, no overflow
Toggle inspector off → window shrinks minimum, content intact
Drag divider narrow, toggle inspector → window auto-expands
Rapid toggle (on/off/on) → minimum size stays correct throughout
MainSplitViewControllerWindowMinimumSizeTests all pass

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d9b71d17e7

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-05-28T13:38:14Z

+    ) {
+        guard let window = view.window else { return }
+
+        let baseWindowContentMinSize = window.contentRect(forFrameRect: NSRect(origin: .zero, size: window.minSize)).size


Preserve the original minimum when recomputing

Because this derives the base from window.minSize after previous calls may have assigned window.contentMinSize, the computed floor can only grow. For example, showing the inspector widens contentMinSize to the pane sum; when hideInspector() calls recomputeWindowMinimumSize(inspectorCollapsed: true), window.minSize already reflects that widened value, so the base remains the larger width and the window never relaxes back to the original 720pt minimum. This keeps narrow editor windows stuck oversized after toggling the inspector once; keep a separate baseline/default content minimum instead of using the current mutable minSize.

Useful? React with 👍 / 👎.

…n race, add test

# Conflicts: # CHANGELOG.md

…imum size

Signed-off-by: Ngô Quốc Đạt <datlechin@gmail.com>

# Conflicts: # CHANGELOG.md

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 07370b753b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-06-04T17:49:21Z

    func showInspector() {
        materializeInspectorIfNeeded()
-        inspectorSplitItem?.animator().isCollapsed = false
+        setCollapsed(false, for: inspectorSplitItem)


Keep the window minimum in sync when expanding panes

When the sidebar is visible, opening the inspector requires about 280 + 400 + 270 points plus dividers, but TabWindowController still leaves the window minSize at 720×480. collapseBehavior can grow the window for this uncollapse, but it does not raise the window's minimum size, so users can immediately drag the same window back down to 720pt with both panes visible and reproduce the squeezed/overflowing split view this change is meant to prevent. Please keep a dynamic content minimum while the extra panes are visible, without deriving it from the already-mutated minimum.

Useful? React with 👍 / 👎.

…vior instead of custom min-size code

… names

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5aa43889a5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-06-04T18:20:34Z

        inspectorSplitItem.canCollapse = true
        inspectorSplitItem.minimumThickness = 270
        inspectorSplitItem.maximumThickness = 400
+        inspectorSplitItem.collapseBehavior = .preferResizingSplitViewWithFixedSiblings


Resize when restoring an already-visible inspector

This only helps when AppKit performs an uncollapse transition; it does not cover the startup path where inspectorPresented is restored and viewDidLoad sets inspectorSplitItem.isCollapsed = false before the window is visible. I checked TabWindowController: it restores and saves MainEditorWindow frames, so a previously saved narrow frame can reopen with the inspector already visible and no collapse animation to trigger this behavior, leaving the same squeezed/overflowing panes until the user toggles the inspector again. Please also handle the initially visible inspector after the window/frame is restored.

Useful? React with 👍 / 👎.

…its quickly

…onnection

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 96dfe45b5d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-06-04T18:27:21Z

+            if let remainingStdout = try? stdoutPipe.fileHandleForReading.readToEnd(), !remainingStdout.isEmpty {
+                stdoutCollector.append(remainingStdout)
+            }
+            if let remainingStderr = try? stderrPipe.fileHandleForReading.readToEnd(), !remainingStderr.isEmpty {
+                stderrCollector.append(remainingStderr)


Avoid blocking indefinitely when draining inherited pipes

If a password command exits after starting a background process that inherits stdout or stderr (for example a shell helper that daemonizes), process.waitUntilExit() returns and the timeout task is canceled, but these readToEnd() calls still wait for EOF on the inherited pipe. That can hang password resolution well past the 30-second timeout even though the command process has already exited; the final drain needs to be non-blocking or still covered by a timeout/closed descriptors.

Useful? React with 👍 / 👎.

chatgpt-codex-connector Bot reviewed May 28, 2026

View reviewed changes

J2TeamNNL force-pushed the fix/inspector branch from d9b71d1 to 0ef3d32 Compare May 28, 2026 13:39

J2TeamNNL added 3 commits June 2, 2026 14:46

fix(inspector): prevent window overflow on inspector pane toggle

6984de3

fix(inspector): add resize call site, refresh base size, fix animatio…

e24ea5b

…n race, add test

fix(inspector): store original content min size to prevent floor drift

77923ac

J2TeamNNL force-pushed the fix/inspector branch from 33c1b8e to 77923ac Compare June 2, 2026 07:50

J2TeamNNL and others added 6 commits June 2, 2026 22:18

Merge remote-tracking branch 'upstream/main' into fix/inspector

a9fae7a

# Conflicts: # CHANGELOG.md

refactor(coordinator): make split controller sole owner of window min…

4e69ac6

…imum size

Merge branch 'main' into fix/inspector

4436989

Signed-off-by: Ngô Quốc Đạt <datlechin@gmail.com>

Merge remote-tracking branch 'upstream/main' into fix/inspector

5f5f4dc

# Conflicts: # CHANGELOG.md

Merge branch 'main' into fix/inspector

799e231

chore: remove accidentally committed Libs/dylibs symlink

3539993

datlechin force-pushed the fix/inspector branch 2 times, most recently from dacabe2 to 07370b7 Compare June 4, 2026 17:47

chatgpt-codex-connector Bot reviewed Jun 4, 2026

View reviewed changes

datlechin added 2 commits June 5, 2026 01:17

refactor(inspector): grow the window via NSSplitViewItem.collapseBeha…

58cd110

…vior instead of custom min-size code

fix(editor): parse schema and table from per-segment-quoted qualified…

5aa4388

… names

datlechin force-pushed the fix/inspector branch from 07370b7 to 5aa4388 Compare June 4, 2026 18:17

chatgpt-codex-connector Bot reviewed Jun 4, 2026

View reviewed changes

datlechin added 2 commits June 5, 2026 01:24

fix(connections): capture full output from a password command that ex…

45075ac

…its quickly

fix(mcp): check cancellation and emit progress before resolving the c…

96dfe45

…onnection

chatgpt-codex-connector Bot reviewed Jun 4, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(inspector): prevent window overflow on inspector pane toggle#1463

fix(inspector): prevent window overflow on inspector pane toggle#1463
J2TeamNNL wants to merge 13 commits into
TableProApp:mainfrom
J2TeamNNL:fix/inspector

J2TeamNNL commented May 28, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot May 28, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot Jun 4, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot Jun 4, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot Jun 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

J2TeamNNL commented May 28, 2026

Summary

Test plan

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot May 28, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Jun 4, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Jun 4, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Jun 4, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants