chore: Improve script cleanup call#1149
Merged
sambuc merged 4 commits intoJun 22, 2026
Merged
Conversation
This was referenced Jun 18, 2026
leafty
reviewed
Jun 22, 2026
| exit_script() { | ||
| function exit_script() { | ||
| echo "Cleaning up session..." | ||
| # fusermount3 -u "${SESSION_WORK_DIR}/era5" || true |
Member
There was a problem hiding this comment.
Note: I think you should keep the unmount placeholder.
Contributor
Author
There was a problem hiding this comment.
I'll keep it until the code to actually unmount things arrives.
Contributor
Author
There was a problem hiding this comment.
(I mean I have put back the line as you suggested)
Base automatically changed from
sambuc/chore/change-environment-into-a-nullable-param
to
feat/secrets-and-dc-in-hpc-sessions
June 22, 2026 09:56
sambuc
force-pushed
the
feat/secrets-and-dc-in-hpc-sessions
branch
from
2d07f3a to
79c35a9
Compare
leafty
approved these changes
Jun 22, 2026
…improve-script-cleanup-call
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Stack