ci: upgrade Playwright to 1.61.0 and re-float Node to lts/*#2303
Merged
Conversation
Bump the playwright override 1.55.1 -> 1.61.0 (current stable) and align the visual-test Docker image to v1.61.0-jammy. Playwright 1.61.0 fixes the `playwright install` extraction hang on Node 24.16.0+, so re-float the exact 24.15.0 pin (STACKS-901 stopgap) to the '24' major. Pin the major rather than lts/* so the runtime can't silently jump to the next LTS major. Visual-regression baselines are regenerated separately from the CI amd64/jammy run, since local arm64 rendering differs. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
✅ Deploy Preview for stacks ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
…aywright-refloat-node
Regenerated from the CI amd64/jammy run (PR #2303 artifact): - Update 1235 Webkit baselines shifted by the Playwright 1.61.0 / Webkit browser bump. Chromium and Firefox renders are byte-identical (unchanged). - Rename 120 stale notice `longText` baselines to `longtext` to match the snapshot name emitted by notice.visual.test.ts; the camelCase files were orphans the current suite no longer produces (committed from a case-insensitive checkout). Done on a case-sensitive volume. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…float-node' into STACKS-902/upgrade-playwright-refloat-node
asblanco
changed the title
asblanco
changed the title
asblanco
commented
Jun 22, 2026
Comment on lines
+9
to
+17
| "overrides": [ | ||
| { | ||
| "files": ".github/**/*.{yml,yaml}", | ||
| "options": { | ||
| "tabWidth": 2, | ||
| "singleQuote": true | ||
| } | ||
| } | ||
| ] |
Contributor
Author
There was a problem hiding this comment.
I had to add this otherwise my editor was reformatting the whole file to 4 tabs (line 2). I thought it's ok to add this as part of the PR, but let me know otherwise
giamir
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
STACKS-902 Upgrade Playwright so CI can return to a floating Node pin
Upgrades Playwright to 1.61.0 and re-floats CI's Node pin to
lts/*, restoring a current, patched toolchain after the STACKS-901 exact-version (24.15.0) stopgap.Acceptance criteria:
24.15.0pin) and pass.playwright@1.61.0+mcr.microsoft.com/playwright:v1.61.0-jammy).Manual testing
Unit Tests,A11y Tests, andUnit Tests (stacks-svelte)(Playwright install completes in minutes, no multi-hour hang) andVisual Regression Tests..icofiles then diff as images; spot-check a sample to confirm benign render differences rather than masked regressions.s-notice-*-longText→longtextbaseline renames align filenames with the snapshot name emitted bynotice.visual.test.ts; the camelCase files were stale orphans the current suite no longer produces.