[Performance] Memoize isWsl#7719
Conversation
Memoize the isWsl function in packages/cli-kit/src/public/node/system.ts by caching the Promise of the dynamic is-wsl import. This avoids redundant imports and environment checks during process execution.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
WHY are these changes introduced?
The
isWslfunction is called during analytics generation and other environment-sensitive paths. Each call triggers a dynamic import of theis-wslpackage and repeated environment/filesystem checks.WHAT is this pull request doing?
This PR memoizes the
isWslfunction by caching the Promise of the dynamic import in a module-level variable. This ensures the import and environment check happen only once per process execution.How to test your changes?
CI
Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset addPR created automatically by Jules for task 13826024206793621349 started by @gonzaloriestra