Skip to content

chore: apply pre-commit hooks across all files#9

Merged
jeanscherf merged 1 commit into
mainfrom
chore/apply-pre-commit-fixes
Mar 24, 2026
Merged

chore: apply pre-commit hooks across all files#9
jeanscherf merged 1 commit into
mainfrom
chore/apply-pre-commit-fixes

Conversation

@jeanscherf

Copy link
Copy Markdown
Member

Description

Apply pre-commit hooks across all files to establish a consistent baseline for the repository. This is a one-time cleanup to ensure all files conform to the project's code quality standards.

Related Issue

N/A - Maintenance task

Type of Change

Please check the relevant option:

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Code refactoring
  • Dependency update

How to Test

  1. Run pre-commit run --all-files - should pass with no changes
  2. Run uv run pytest - all tests should pass
  3. Run uv run ruff check . - no issues reported

Checklist

Before submitting your PR, please review and check the following:

  • I have read the Contributing Guidelines
  • I have verified that my changes solve the issue
  • I have added/updated automated tests to cover my changes
  • All tests pass locally
  • I have verified that my code follows the Code Guidelines
  • I have updated documentation (if applicable)
  • I have added type hints for all public APIs
  • My code does not contain sensitive information (credentials, tokens, etc.)
  • I have followed Conventional Commits for commit messages

Breaking Changes

N/A - No breaking changes. These are formatting-only changes.

Additional Notes

Changes applied by pre-commit hooks:

  • end-of-file-fixer: Ensured all files end with a newline (27 files)
  • trailing-whitespace: Removed trailing whitespace (47 files)

Files modified (60 total):

GitHub configuration:

  • .github/CODEOWNERS
  • .github/ISSUE_TEMPLATE/bug-report.yml, feature-request.yml, question.yml
  • .github/dependabot.yml
  • .github/pull_request_template.md
  • .github/workflows/*.yaml (8 files)

Documentation:

  • CONTRIBUTING.md
  • docs/GUIDELINES.md, docs/RELEASE.md
  • User guides for auditlog, destination, objectstore, secret_resolver modules

Test files:

  • All test files across aicore, core, destination, and objectstore modules

Other:

  • mocks/destination.json

@jeanscherf jeanscherf requested a review from a team as a code owner March 24, 2026 16:08
@jeanscherf jeanscherf merged commit 8c03fbf into main Mar 24, 2026
10 checks passed
@jeanscherf jeanscherf deleted the chore/apply-pre-commit-fixes branch March 24, 2026 17:39
lenin-ribeiro added a commit that referenced this pull request Jun 22, 2026
Address two review comments from @NicoleMGomes on the post-restructure
PR state:

- README.md: drop the breaking-change callout (review #9). The PR body
  + aicore user-guide carry the relevant migration detail; the README
  doesn't need release-notes-style content per change.
- _litellm_patch.py: tighten 'except Exception: pass' to 'except ValueError'
  around the json() call only (review #10). The previous broad except
  would swallow logic bugs in ContentFilteredError(...) construction;
  the narrower catch handles only the realistic failure mode
  (non-JSON response body) and lets logic errors surface. Applied
  symmetrically to both input-filter and output-filter detection
  branches.

Also satisfy CI's stricter ty by adding 'ty: ignore[too-many-positional-arguments]'
to two deliberately-failing positional-call sites in test_filters.py
(test_kwarg_only). The existing 'type: ignore[misc]' was sufficient for
mypy but not for the CI ty version.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants