test(destination): add regression test for multi-label OData filter#154
Merged
Conversation
Verifies that ListOptions with multiple filter_labels generates a valid OData HAS expression joined by AND, using real label keys from the sap-managed-runtime domain (AFSDK-3656). The no-parens format is what the Destination Service API accepts. Parenthesized clauses return 400 — confirmed against live API.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_multiple_labels_real_keystoTestListOptionsLabelFilter— a regression guard that verifiesListOptionswith twofilter_labelsproduces the correct ODataHAS ... AND ...expression using realsap-managed-runtime-*label keysThe ticket claimed the multi-label filter was broken and required parentheses around each clause. Testing against the live Destination Service API proved the opposite:
Label['a'] HAS ('v') AND Label['b'] HAS ('v')— current SDK output200 OK(Label['a'] HAS ('v')) AND (Label['b'] HAS ('v'))— format ticket described as "required"400 The provided filter is not recognizedThe no-parens format the SDK already generates is correct. UC-9455 (connectivity team fix) enabled multi-label support on the service side — confirmed working end-to-end against
app-fnd-sdk-test-canary-eu12with real fragments.Test plan
pytest tests/destination/unit/test_models.py::TestListOptionsLabelFilter— all 11 tests pass