Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #4936 +/- ##
===========================================
- Coverage 92.66% 92.62% -0.04%
===========================================
Files 588 587 -1
Lines 30412 30456 +44
===========================================
+ Hits 28180 28208 +28
- Misses 2232 2248 +16
🚀 New features to boost your workflow:
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| repeat_c<4>([&](auto j) { | ||
| const int32_t e_off = (hi[i] and wj[j]) ? off + static_cast<int>(i) * sh_b + | ||
| static_cast<int>(j) * sw_b | ||
| : oob_byte; |
Contributor
There was a problem hiding this comment.
[format.py] reported by reviewdog 🐶
Suggested change
| : oob_byte; | |
| : oob_byte; |
klin2024
reviewed
Jun 8, 2026
| match::find_matches(mpm, find_gemm_softmax_gemm{enable_attention}); | ||
| if(is_navi) | ||
| match::find_matches(mpm.get_module(), find_channelwise_convolution{}); | ||
| if(is_gfx12) |
Contributor
There was a problem hiding this comment.
Do we have plans to support gfx11?
Collaborator
Author
There was a problem hiding this comment.
Yes I do. It might already work on gfx11 but I havent tested it yet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Technical Details
Changelog Category
Add a
CHANGELOG.mdentry for any option other thanNot Applicable