refactor(router): bake boundary layout chains at build time#8771
Open
briancarbone wants to merge 2 commits into
Open
refactor(router): bake boundary layout chains at build time#8771briancarbone wants to merge 2 commits into
briancarbone wants to merge 2 commits into
Conversation
|
briancarbone
force-pushed
the
refactor/bake-boundary-layouts
branch
2 times, most recently
from
ba379cc to
ef9002b
Compare
@qwik.dev/core
@qwik.dev/router
eslint-plugin-qwik
create-qwik
@qwik.dev/optimizer
commit: |
Contributor
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
wmertens
reviewed
Jun 25, 2026
wmertens
left a comment
wmertens
left a comment
Member
There was a problem hiding this comment.
On my phone, can't do a proper review yet, but could you add the route config as one of the SSG snapshot tests? Before this change. Then after the change we can easily see the effect
briancarbone
force-pushed
the
refactor/bake-boundary-layouts
branch
4 times, most recently
from
9381c6d to
ac0eb39
Compare
Capture @qwik-router-config during the ssg-snapshot client build and compare it to a committed golden (expected.config.txt). Route-trie changes — layouts, 404/error boundaries, loader placeholders — now surface as a reviewable diff in the PR that makes them, addressing the review ask to see route-config effects.
`_4`/`_E` boundaries now carry their layout chain resolved at build time and render it as-is on both a miss and a thrown error, replacing the per-boundary runtime layout-snapshot machinery. Error boundaries follow the same model as `_I`: a bare `error.tsx` renders in its layouts, `error!.tsx` standalone, and `error@name.tsx` in the named layout. Also fixes a pre-existing gap where a `[...rest]` node's own boundaries and loaders were dropped on an empty-rest match.
briancarbone
force-pushed
the
refactor/bake-boundary-layouts
branch
from
ac0eb39 to
bee1e85
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.