fix: keep unset p_set as NaN in cluster_heat_buses aggregation#2202
Open
lkstrp wants to merge 3 commits into
Open
fix: keep unset p_set as NaN in cluster_heat_buses aggregation#2202lkstrp wants to merge 3 commits into
lkstrp wants to merge 3 commits into
Conversation
FabianHofmann
approved these changes
Jun 12, 2026
FabianHofmann
left a comment
FabianHofmann
left a comment
Contributor
There was a problem hiding this comment.
great! feel free to ignore or tackle the comment. In the long term we should consolidate clustering techniques (but out of scope here)
Comment on lines
+5698
to
+5703
| def _sum_keep_na(s): | ||
| """ | ||
| Sum keeping all-NaN groups as NaN instead of collapsing them to 0. | ||
|
|
||
| """ | ||
| return s.sum(min_count=1) |
Contributor
There was a problem hiding this comment.
rather in helpers.py?
Member
Author
There was a problem hiding this comment.
I guess everywhere else you should rather just pass s.sum(min_count=1) directly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2182
See PyPSA/PyPSA#1703