Foundation: Replaces libsass with dart sass binary#2511
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
... and 114 files with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
Daverball
reviewed
Jun 16, 2026
Daverball
left a comment
Daverball
left a comment
Member
There was a problem hiding this comment.
Looks good overall, I'm not sure about the src portion of the install though and I think we can simplify the install for local development and install it directly inside the virtual environment.
Daverball
reviewed
Jun 17, 2026
Relocates the dart-sass install so it runs after the venv/build stage and drops the redundant mkdir -p /app/bin.
The container doesn't activate the venv, so /app/bin isn't on PATH; sass was unreachable at runtime.
Daverball
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please fill in the commit message below and work through the checklist. You can delete parts that are not needed, e.g. the optional description, the link to a ticket or irrelevant options of the checklist.
Commit message
Foundation: Replaces libsass with dart sass binary
Dart Sass is the primary implementation of Sass,
TYPE: Feature
LINK: OGC-3071
Checklist