[15.0][IMP] template_content_swapper: allow manual editing of the name#1305
Open
smorita7749 wants to merge 1 commit into
Open
[15.0][IMP] template_content_swapper: allow manual editing of the name#1305smorita7749 wants to merge 1 commit into
smorita7749 wants to merge 1 commit into
Conversation
OCA-git-bot
added
series:15.0
mod:template_content_swapper
| return self.env["res.lang"].get_installed() | ||
|
|
||
| name = fields.Char(compute="_compute_name", store=True, readonly=True) | ||
| name = fields.Char() |
Contributor
There was a problem hiding this comment.
Isn't it possible just by changing readonly to False?
Contributor
There was a problem hiding this comment.
Do you want to add name before inserting content values? Is that the reason?
yostashiro
reviewed
Jun 25, 2026
| return self.env["res.lang"].get_installed() | ||
|
|
||
| name = fields.Char(compute="_compute_name", store=True, readonly=True) | ||
| name = fields.Char() |
Member
There was a problem hiding this comment.
Suggested change
| name = fields.Char() | |
| name = fields.Char(required=True) |
Comment on lines
+40
to
+44
| @api.onchange("content_from", "content_to", "name") | ||
| def _onchange_content(self): | ||
| """Auto-fill the name from the contents while empty; keep manual names.""" | ||
| if not self.name and self.content_from and self.content_to: | ||
| self.name = f"{self.content_from} -> {self.content_to}" |
Member
There was a problem hiding this comment.
To keep it simple, as names currently tend to look cluttered.
Suggested change
| @api.onchange("content_from", "content_to", "name") | |
| def _onchange_content(self): | |
| """Auto-fill the name from the contents while empty; keep manual names.""" | |
| if not self.name and self.content_from and self.content_to: | |
| self.name = f"{self.content_from} -> {self.content_to}" | |
| @api.onchange("content_from") | |
| def _onchange_content(self): | |
| """Auto-fill the name from the contents while empty; keep manual names.""" | |
| if not self.name and self.content_from: | |
| self.name = self.content_from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change allows users to edit the mapping name manually.
@qrtl QT6819