[18.0][FIX] base_tier_validation_forward: fix forward notification delivery#1279
Open
llabusch93 wants to merge 1 commit into
Open
[18.0][FIX] base_tier_validation_forward: fix forward notification delivery#1279llabusch93 wants to merge 1 commit into
llabusch93 wants to merge 1 commit into
Conversation
Two bugs prevent forwarded review notifications from reaching the target user: 1. _get_forwarded_notification_subtype() returns the wrong xmlid "base_tier_validation.mt_tier_validation_forwarded" but the mail.message.subtype record is defined in base_tier_validation_forward. message_post() silently falls back to mail.mt_note (internal note) which does not generate email notifications for followers. 2. The forward wizard add_forward() creates a tier.review for the target user but never calls message_subscribe(). Without being a follower of the record, the target user cannot receive any email notifications — even if the subtype were correct. Combined effect: when a reviewer forwards their approval to another user, the target user is never notified and the forward appears to "not work" from the end-user perspective. Fixes: - Correct the module prefix in _get_forwarded_notification_subtype() - Call message_subscribe() in add_forward() to subscribe the forward target as a follower with the forward notification subtype
Contributor
|
Hi @kittiu, |
Saran440
approved these changes
Jun 2, 2026
Member
There was a problem hiding this comment.
Code Review 👍
@llabusch93 Could you change Title to add version, please?
[18.0][FIX] base.....
llabusch93
changed the title
Author
|
@Saran440 Done — updated the title to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two bugs in
base_tier_validation_forwardprevent forwarded review notifications from reaching the target user:Bug 1 — Wrong
subtype_xmlid:_get_forwarded_notification_subtype()returns"base_tier_validation.mt_tier_validation_forwarded"but themail.message.subtyperecord is defined in thebase_tier_validation_forwardmodule (seedata/mail_data.xml). Whenmessage_post()cannot resolve the xmlid, it silently falls back tomail.mt_note— internal notes do not generate email notifications for followers.Bug 2 — Forward target not subscribed as follower: The forward wizard
add_forward()creates atier.reviewfor the target user but never callsmessage_subscribe(). Without being a follower of the record, the target user cannot receive email notifications even if the subtype were correct.Combined effect: When a reviewer forwards their approval to another user, the target user is never notified by email. The forward "works" technically (the review record is created), but the target user has no way of knowing they need to act — unless they happen to be actively browsing the record's chatter.
Changes
models/tier_validation.py: Fix the module prefix in_get_forwarded_notification_subtype()frombase_tier_validation→base_tier_validation_forwardwizard/forward_wizard.py: Callmessage_subscribe()inadd_forward()to subscribe the forward target as a follower with the forward notification subtypetests/test_tier_validation.py: Add 3 tests — subtype xmlid correctness, message subtype verification, follower subscription after forward