refactor: unify android runtime c++ layout#45
Open
DjDeveloperr wants to merge 11 commits into
Open
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NativeScript/ffi/objcand Android JNI Node-API interop underNativeScript/ffi/jni/napiNativeScript/runtime/androidand Android engine shims intoNativeScript/napi/androidplatforms/android, restore Android SHERMES-compatible headers, and preserve the shared Hermes runtime surface used by AppleValidation
npm run buildnpm run build:macos-clinpm run check:ffi-boundariesnpm run test:macos->SUCCESS: 713 specs, 0 failures, 10 skipped, 0 disablednpm run test:ios->SUCCESS: 713 specs, 0 failures, 13 skipped, 0 disabled./gradlew --no-daemon --console=plain -Dandroid.builder.sdkDownload=false -b runtests.gradle runtestsAndVerifyResults -Pengine=<engine> -PndkDirectory=$ANDROID_NDK_ROOT -PndkVersion=27.1.12297006QUICKJS: 427 tests, 0 failures, 12 skippedQUICKJS_NG: 427 tests, 0 failures, 12 skippedHERMES: 399 tests, 0 failures, 52 skippedSHERMES: 375 tests, 0 failures, 51 skippedJSC: 396 tests, 0 failures, 36 skippedPRIMJS: 427 tests, 0 failures, 12 skippedV8-10: 427 tests, 0 failures, 12 skippedV8-11: 427 tests, 0 failures, 12 skippedV8-13: 427 tests, 0 failures, 12 skippedgit diff --check