Allow topology-only builds at configure time#141
Merged
Conversation
pentschev
approved these changes
Jun 2, 2026
pentschev
left a comment
pentschev
left a comment
Contributor
There was a problem hiding this comment.
Changes being tested in rapidsai/rapidsmpf#1080. Once CI passes there we can merge this.
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
Author
|
Converting to draft. This was a workaround that I thought we might need as part of rapidsai/cudf#22747, but at least for the moment we seem to be avoiding any issues in the jobs that do involve refetching cuCascade. I'll keep this in draft for now just in case an edge case pops up while we're moving through the rapidsmpf->cudf transition. |
Contributor
Author
|
I think we are going to need this to be able to merge rapidsai/cudf#22786 safely. |
bdice
approved these changes
Jun 5, 2026
mbrobbel
approved these changes
Jun 5, 2026
Contributor
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The topology split in #126 prevented the build of non-topology components of cuCascade when they aren't needed, but it still configures assuming everything is built, which means that it tries to find rmm and cudf. That can still lead to more circular dependency issues depending on exactly how builds are done, so we need a heavier hammer to avoid that. This PR implements a CMake flag to turn off every part of the non-topology build when needed.