fix: Fix the default setting in Nemo Gym Nano v3 recipe config#2857
Open
snowmanwwg wants to merge 4 commits into
Open
fix: Fix the default setting in Nemo Gym Nano v3 recipe config#2857snowmanwwg wants to merge 4 commits into
snowmanwwg wants to merge 4 commits into
Conversation
Signed-off-by: Wenwen Gao <wenweng@cw-dfw-cs-001-vscode-01.cm.cluster>
added 2 commits
June 16, 2026 22:58
Signed-off-by: Wenwen Gao <wenweng@cw-dfw-cs-001-vscode-01.cm.cluster>
Signed-off-by: Wenwen Gao <wenweng@cw-dfw-cs-001-vscode-01.cm.cluster>
snowmanwwg
changed the title
terrykong
approved these changes
Jun 17, 2026
terrykong
added
the
CI:Lfast
Collaborator
|
/ok to test 324d965 |
Collaborator
|
/ok to test 8a5c7bb |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
This PR disables the draft model for default setting in https://github.com/NVIDIA-NeMo/RL/blob/main/examples/nemo_gym/grpo_nanov3.yaml
. It mirrors what was done in https://github.com/NVIDIA-NeMo/RL/blob/main/examples/configs/grpo_math_1B.yaml#L258
Issues
Without this fix. Running this https://github.com/NVIDIA-NeMo/RL/blob/main/examples/nemo_gym/grpo_nanov3.yaml
gives an KeyError: 'draft' at config.policy["draft"]["enabled"] (https://github.com/NVIDIA-NeMo/RL/blob/main/examples/run_grpo.py#L104)
Before your PR is "Ready for review"
Pre checks:
Additional Information