GTFS Diff schema v2-rc1 update#19
Conversation
| "minimum": 0, | ||
| "description": "Total number of rows in the base version of the file." | ||
| }, | ||
| "total_rows_new": { |
There was a problem hiding this comment.
Do we need to add total_rows_modified?
There was a problem hiding this comment.
Whats the diff with rows_modified_count?
There was a problem hiding this comment.
Sorry, I was too focused on the differences. Here we have a few fields: rows_added_count, rows_deleted_count, and rows_modified_count on a file diff node; then we have the stats on the node with some metrics. We should align these metrics by adding all fields to the root of the diff node and removing the stats node, or moving them all to the stats node(I'm ok either way). And use total_rows_modified or rows_modified_count not both. Thoughts?
There was a problem hiding this comment.
Agreed. I kept all stats in the stats node and have stats exclusively in the file_diff node to avoid duplication
Co-authored-by: jcpitre <106176106+jcpitre@users.noreply.github.com>
Co-authored-by: jcpitre <106176106+jcpitre@users.noreply.github.com>
jcpitre
left a comment
There was a problem hiding this comment.
2 small comments, but apart from that LGTM!
Co-authored-by: jcpitre <106176106+jcpitre@users.noreply.github.com>
Summary:
additionalPropertiesconstraints to support extensionsnot_comparedfile status with a reason object (code+message) for files that cannot be meaningfully comparedignored_columnsto file diffs for columns excluded due to unreliable values (e.g. referencing a file that isn't compared)files_not_compared_countto the summary