-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
MDEV-39806: Add a per-push/per-pull-request checker for Markdown API docs #5153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| name: Generate Plugin API Docs | ||
|
|
||
| on: | ||
| push: | ||
| branches: | ||
| - 'main' | ||
| - 'bb-*' | ||
| pull_request: | ||
| branches: | ||
| - 'main' | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This will only trigger if someone opens a Pull Request towards main or a bb-* branch. |
||
| - 'bb-*' | ||
| jobs: | ||
| generate-docs: | ||
| runs-on: ubuntu-latest | ||
| container: | ||
| image: quay.io/mariadb-foundation/bb-ecosystem:mariadb-doc-gen | ||
| steps: | ||
| - name: Checkout repository | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Generate documentation | ||
| shell: bash | ||
| run: | | ||
| set -euo pipefail | ||
| git config --global --add safe.directory `pwd` | ||
| git submodule update --init --recursive libmariadb | ||
| mkdir bld | ||
| cd bld | ||
| cmake -DENABLE_GCOV=OFF \ | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You could've probably used |
||
| -DMYSQL_MAINTAINER_MODE=OFF \ | ||
| -DPLUGIN_ARCHIVE=NO \ | ||
| -DPLUGIN_MROONGA=NO \ | ||
| -DPLUGIN_CONNECT=NO \ | ||
| -DPLUGIN_SPIDER=NO \ | ||
| -DPLUGIN_ROCKSDB=NO \ | ||
| -DPLUGIN_OQGRAPH=NO \ | ||
| -DPLUGIN_TOKUDB=NO \ | ||
| -DWITH_MARIABACKUP=NO \ | ||
| -DWITH_EMBEDDED_SERVER=OFF \ | ||
| -DWITH_UNIT_TESTS=OFF \ | ||
| -DCONC_WITH_UNITTEST=OFF \ | ||
| -DWITH_WSREP=OFF \ | ||
| -DWITHOUT_DYNAMIC_PLUGINS=0 \ | ||
| -DWITH_SSL=system \ | ||
| -DWITH_PCRE=system \ | ||
| -DWITHOUT_SERVER=ON \ | ||
| -DUPDATE_SUBMODULES=OFF \ | ||
| -DWITH_GENERATED_DOCS=YES \ | ||
| .. | ||
| cmake --build . --target=generated_docs_plugin_api | ||
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want this workflow to run on other branches and on Pull Requests that are not targeting
mainthen it is not enough to commit it to the
mainbranch.Every supported branch should have it.
Going one step back,
why you want this workflow to run for every
pushorbb-*branch?This is a lot of stress imposed on public GitHub runners; where's the added value? Because I see no mechanism where the results from a push are retrieved/analyzed.