pico: pin V toolchain to latest upstream commit#919
Open
enghitalo wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
/benchmark -f pico |
Contributor
|
👋 |
Contributor
Benchmark ResultsFramework:
Full log |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pin the V toolchain used by frameworks/pico from c0624b274 to the latest upstream V master commit 6c4d26f1f.
Why this can improve benchmark results
Recent V upstream changes in this range include runtime-oriented improvements relevant to tight HTTP loops:
a << x), fixes #27468 vlang/v#27470<<) 4-7x slower on master vs 0.5.1 (alloc, push_many, indexed-write unaffected) vlang/v#27468.Closed issue references
<<) 4-7x slower on master vs 0.5.1 (alloc, push_many, indexed-write unaffected) vlang/v#27468 (fixed by PR #27470)Scope