452 fix flaky test#453
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a flaky functional test by making GetDatasetAvailableDatasetTypes.test.ts tolerant of additional dataset types that may be present when tests run concurrently (e.g., interference from AddDatasetType.test.ts).
Changes:
- Replaces a strict full-array equality assertion with a presence-based assertion for the default
"dataset"type. - Refactors the expected value from an array (
expectedDatasetTypes) to a single object (expectedDatasetType) to match the new assertion style.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ChengShi-1
approved these changes
Jun 4, 2026
Contributor
ChengShi-1
left a comment
ChengShi-1
left a comment
There was a problem hiding this comment.
Thanks for the fix. looks good
github-project-automation
Bot
moved this from Ready for Review ⏩
to Ready for QA ⏩
in IQSS Dataverse Project
github-project-automation
Bot
moved this from Ready for QA ⏩
to Merged 🚀
in IQSS Dataverse Project
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Updates GetDatasetAvailableDatasetTypes so it doesn't fail if there is an additional datasetType returned due to a concurrent test.
Which issue(s) this PR closes: