Add defineCustomElement helper and refactor components#1
Open
0xDazzer wants to merge 3 commits into
Open
Conversation
Introduce a defineCustomElement factory that wires up the shadow DOM, template cloning, observed attributes and element references, then refactor the profile components to use it. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
0xDazzer
force-pushed
the
refactor-define-custom-element
branch
from
1f15b95 to
d47feac
Compare
Resolve leftover direct this.<el> access that survived conflict resolution and would be undefined on the refactored components: - profile-search: this.nameInput/this.emailInput - profile-directory: this.list - profile-item: this.openBtn/this.deleteBtn Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
defineCustomElementfactory (static/define-custom-element.mjs) that encapsulates the boilerplate of defining a custom element: attaching the shadow root, cloning the template content, declaringobservedAttributes, and resolving element references by id.Changes
static/define-custom-element.mjs🤖 Generated with Claude Code