Skip to content

Feat/sigma rules import summary step#26320

Open
zeeklop wants to merge 10 commits into
masterfrom
feat/sigma-rules-import-summary-step
Open

Feat/sigma rules import summary step#26320
zeeklop wants to merge 10 commits into
masterfrom
feat/sigma-rules-import-summary-step

Conversation

@zeeklop

@zeeklop zeeklop commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Made the render methods in the Event Definition summary step reusable

/nocl

Description

Made these methods reusable to be able to keep consistency across the application. This modification made possible add the missing information in the sigma import summary step

Motivation and Context

Keep consistency across the application

How Has This Been Tested?

Unit test

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have requested a documentation update.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Refactors the Event Definition “Summary” step by extracting its rendering logic into reusable helpers, and makes the summary step part of the shared/common wizard steps so it can be reused consistently across the app (e.g., for Sigma-related flows).

Changes:

  • Extracted condition/fields/notifications/event-procedure/remediation rendering into a new useEventDefinitionSummaryRenders.tsx helper module.
  • Added a Summary step to useEventDefinitionCommonSteps (with optional summaryComponent override) and removed the ad-hoc summary-step push from EventDefinitionFormContainer.
  • Updated EventDefinitionSummary to consume the new reusable render helpers/hooks.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
graylog2-web-interface/src/components/event-definitions/event-definition-form/useEventDefinitionSummaryRenders.tsx New reusable summary render helpers/hooks (conditions, fields, notifications, event procedure/remediation, techniques).
graylog2-web-interface/src/components/event-definitions/event-definition-form/useEventDefinitionCommonSteps.tsx Adds a reusable Summary step (optionally overridable via summaryComponent).
graylog2-web-interface/src/components/event-definitions/event-definition-form/EventDefinitionSummary.tsx Refactors summary rendering to delegate to the new helper functions/hooks.
graylog2-web-interface/src/components/event-definitions/event-definition-form/EventDefinitionFormContainer.tsx Removes manual summary-step insertion (now handled by common steps).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@danotorrey danotorrey left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and test successfully!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants