Feat/sigma rules import summary step#26320
Open
zeeklop wants to merge 10 commits into
Open
Conversation
…t/sigma-rules-import-summary-step
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors the Event Definition “Summary” step by extracting its rendering logic into reusable helpers, and makes the summary step part of the shared/common wizard steps so it can be reused consistently across the app (e.g., for Sigma-related flows).
Changes:
- Extracted condition/fields/notifications/event-procedure/remediation rendering into a new
useEventDefinitionSummaryRenders.tsxhelper module. - Added a
Summarystep touseEventDefinitionCommonSteps(with optionalsummaryComponentoverride) and removed the ad-hoc summary-step push fromEventDefinitionFormContainer. - Updated
EventDefinitionSummaryto consume the new reusable render helpers/hooks.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| graylog2-web-interface/src/components/event-definitions/event-definition-form/useEventDefinitionSummaryRenders.tsx | New reusable summary render helpers/hooks (conditions, fields, notifications, event procedure/remediation, techniques). |
| graylog2-web-interface/src/components/event-definitions/event-definition-form/useEventDefinitionCommonSteps.tsx | Adds a reusable Summary step (optionally overridable via summaryComponent). |
| graylog2-web-interface/src/components/event-definitions/event-definition-form/EventDefinitionSummary.tsx | Refactors summary rendering to delegate to the new helper functions/hooks. |
| graylog2-web-interface/src/components/event-definitions/event-definition-form/EventDefinitionFormContainer.tsx | Removes manual summary-step insertion (now handled by common steps). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…t/sigma-rules-import-summary-step
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…ylog2/graylog2-server into feat/sigma-rules-import-summary-step
danotorrey
approved these changes
Jun 12, 2026
danotorrey
left a comment
Contributor
There was a problem hiding this comment.
LGTM and test successfully!
…t/sigma-rules-import-summary-step
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made the render methods in the Event Definition summary step reusable
/nocl
Description
Made these methods reusable to be able to keep consistency across the application. This modification made possible add the missing information in the sigma import summary step
Motivation and Context
Keep consistency across the application
How Has This Been Tested?
Unit test
Screenshots (if appropriate):
Types of changes
Checklist: