Skip to content

Use cargo workspace to remove duplicated version, license, and author fields #4226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
timon-schelling wants to merge 1 commit into
base: relicense
Choose a base branch
from
Open

Use cargo workspace to remove duplicated version, license, and author fields #4226

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
62 changes: 31 additions & 31 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ default-members = [
"node-graph/node-macro",
"node-graph/preprocessor",
# blocked by https://github.com/rust-lang/cargo/issues/16000
# "proc-macros",
# "proc-macros",
"tools/cargo-run",
]
resolver = "2"
Expand Down
14 changes: 7 additions & 7 deletions desktop/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
[package]
name = "graphite-desktop"
version = "0.1.0"
description = "Graphite Desktop"
authors = ["Graphite Authors <contact@graphite.art>"]
license = "MIT OR Apache-2.0"
repository = ""
edition = "2024"
rust-version = "1.87"

@gemini-code-assist gemini-code-assist Bot Jun 11, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The rust-version constraint was removed during the workspace migration. Please add rust-version.workspace = true to ensure the package adheres to the workspace's Rust version constraint.

Suggested change
rust-version = "1.87"
rust-version.workspace = true

# Inherited from workspace - start
version.workspace = true
license.workspace = true
authors.workspace = true
edition.workspace = true
publish.workspace = true

@cubic-dev-ai cubic-dev-ai Bot Jun 11, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: The rust-version constraint (previously "1.87") was removed but not replaced with rust-version.workspace = true. This drops the MSRV enforcement for this package.

Prompt for AI agents 
Check if this issue is valid — if so, understand the root cause and fix it. At desktop/Cargo.toml, line 8:

<comment>The `rust-version` constraint (previously `"1.87"`) was removed but not replaced with `rust-version.workspace = true`. This drops the MSRV enforcement for this package.</comment>

<file context>
@@ -1,12 +1,12 @@
+license.workspace = true
+authors.workspace = true
+edition.workspace = true
+publish.workspace = true
+# Inherited from workspace - end
 
</file context>
Suggested change
publish.workspace = true
publish.workspace = true
rust-version.workspace = true

@cubic-dev-ai cubic-dev-ai Bot Jun 11, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P3: The description = "Graphite Desktop" field was removed without inheriting one from the workspace, so the crate now has no description. Workspace [workspace.package] does not define a description field, so this is a net loss. Other migrated crates here (editor, desktop/wrapper) never had descriptions, so they weren't affected.

Prompt for AI agents 
Check if this issue is valid — if so, understand the root cause and fix it. At desktop/Cargo.toml, line 8:

<comment>The `description = "Graphite Desktop"` field was removed without inheriting one from the workspace, so the crate now has no description. Workspace `[workspace.package]` does not define a `description` field, so this is a net loss. Other migrated crates here (editor, desktop/wrapper) never had descriptions, so they weren't affected.</comment>

<file context>
@@ -1,12 +1,12 @@
+license.workspace = true
+authors.workspace = true
+edition.workspace = true
+publish.workspace = true
+# Inherited from workspace - end
 
</file context>

# Inherited from workspace - end

[[bin]]
name = "graphite"
Expand Down
13 changes: 7 additions & 6 deletions desktop/bundle/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,13 @@
[package]
name = "graphite-desktop-bundle"
version = "0.0.0"
description = "Graphite Desktop Bundle"
authors = ["Graphite Authors <contact@graphite.art>"]
license = "MIT OR Apache-2.0"
repository = ""
edition = "2024"
rust-version = "1.87"

@gemini-code-assist gemini-code-assist Bot Jun 11, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The rust-version constraint was removed during the workspace migration. Please add rust-version.workspace = true to ensure the package adheres to the workspace's Rust version constraint.

Suggested change
rust-version = "1.87"
rust-version.workspace = true

# Inherited from workspace - start
version.workspace = true
license.workspace = true
authors.workspace = true
edition.workspace = true
publish.workspace = true
# Inherited from workspace - end

[dependencies]
cef-dll-sys = { workspace = true }
Expand Down
14 changes: 7 additions & 7 deletions desktop/embedded-resources/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
[package]

@cubic-dev-ai cubic-dev-ai Bot Jun 11, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: Dropping the crate's rust-version declaration removes its MSRV metadata. Cargo will no longer reject older toolchains for this package up front, so restore the field (or inherit it explicitly) if this crate still supports a minimum Rust version.

Prompt for AI agents 
Check if this issue is valid — if so, understand the root cause and fix it. At desktop/embedded-resources/Cargo.toml, line 4:

<comment>Dropping the crate's `rust-version` declaration removes its MSRV metadata. Cargo will no longer reject older toolchains for this package up front, so restore the field (or inherit it explicitly) if this crate still supports a minimum Rust version.</comment>

<file context>
@@ -1,12 +1,12 @@
-edition = "2024"
-rust-version = "1.87"
+# Inherited from workspace - start
+version.workspace = true
+license.workspace = true
+authors.workspace = true
</file context>
Suggested change
[package]
version.workspace = true
license.workspace = true
authors.workspace = true
edition.workspace = true
rust-version = "1.87"
publish.workspace = true

name = "graphite-desktop-embedded-resources"
version = "0.1.0"
description = "Graphite Desktop Embedded Resources"
authors = ["Graphite Authors <contact@graphite.art>"]
license = "MIT OR Apache-2.0"
repository = ""
edition = "2024"
rust-version = "1.87"

@gemini-code-assist gemini-code-assist Bot Jun 11, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The rust-version constraint was removed during the workspace migration. Please add rust-version.workspace = true to ensure the package adheres to the workspace's Rust version constraint.

Suggested change
rust-version = "1.87"
rust-version.workspace = true

# Inherited from workspace - start
version.workspace = true
license.workspace = true
authors.workspace = true
edition.workspace = true
publish.workspace = true
# Inherited from workspace - end

[dependencies]
include_dir = { workspace = true }
Expand Down
14 changes: 7 additions & 7 deletions desktop/platform/linux/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
[package]
name = "graphite-desktop-platform-linux"
version = "0.0.0"
description = "Graphite Desktop Platform Linux"
authors = ["Graphite Authors <contact@graphite.art>"]
license = "MIT OR Apache-2.0"
repository = ""
edition = "2024"
rust-version = "1.87"

@gemini-code-assist gemini-code-assist Bot Jun 11, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The rust-version constraint was removed during the workspace migration. Please add rust-version.workspace = true to ensure the package adheres to the workspace's Rust version constraint.

Suggested change
rust-version = "1.87"
rust-version.workspace = true

# Inherited from workspace - start
version.workspace = true
license.workspace = true
authors.workspace = true
edition.workspace = true
publish.workspace = true
# Inherited from workspace - end

[[bin]]
name = "graphite"
Expand Down
14 changes: 7 additions & 7 deletions desktop/platform/mac/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
[package]

@cubic-dev-ai cubic-dev-ai Bot Jun 11, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P3: Removing the description field without a workspace replacement loses the crate description. The workspace [workspace.package] does not define description, so this crate will now have no description metadata.

Prompt for AI agents 
Check if this issue is valid — if so, understand the root cause and fix it. At desktop/platform/mac/Cargo.toml, line 4:

<comment>Removing the `description` field without a workspace replacement loses the crate description. The workspace `[workspace.package]` does not define `description`, so this crate will now have no description metadata.</comment>

<file context>
@@ -1,12 +1,12 @@
-edition = "2024"
-rust-version = "1.87"
+# Inherited from workspace - start
+version.workspace = true
+license.workspace = true
+authors.workspace = true
</file context>

name = "graphite-desktop-platform-mac"
version = "0.0.0"
description = "Graphite Desktop Platform Mac"
authors = ["Graphite Authors <contact@graphite.art>"]
license = "MIT OR Apache-2.0"
repository = ""
edition = "2024"
rust-version = "1.87"

@gemini-code-assist gemini-code-assist Bot Jun 11, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The rust-version constraint was removed during the workspace migration. Please add rust-version.workspace = true to ensure the package adheres to the workspace's Rust version constraint.

Suggested change
rust-version = "1.87"
rust-version.workspace = true

# Inherited from workspace - start

@cubic-dev-ai cubic-dev-ai Bot Jun 11, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: Custom agent: PR title enforcement

PR title has a spelling error: "dublicated" should be "duplicated". The PR title becomes the commit message, and the project's detailed PR title style guide establishes high standards for spelling and language correctness.

Prompt for AI agents 
Check if this issue is valid — if so, understand the root cause and fix it. At desktop/platform/mac/Cargo.toml, line 3:

<comment>PR title has a spelling error: "dublicated" should be "duplicated". The PR title becomes the commit message, and the project's detailed PR title style guide establishes high standards for spelling and language correctness.</comment>

<file context>
@@ -1,12 +1,12 @@
-repository = ""
-edition = "2024"
-rust-version = "1.87"
+# Inherited from workspace - start
+version.workspace = true
+license.workspace = true
</file context>

@cubic-dev-ai cubic-dev-ai Bot Jun 11, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: Custom agent: PR title enforcement

PR title starts with invalid leading verb "Use" instead of an approved action verb from the project's leading verb vocabulary

Prompt for AI agents 
Check if this issue is valid — if so, understand the root cause and fix it. At desktop/platform/mac/Cargo.toml, line 3:

<comment>PR title starts with invalid leading verb "Use" instead of an approved action verb from the project's leading verb vocabulary</comment>

<file context>
@@ -1,12 +1,12 @@
-repository = ""
-edition = "2024"
-rust-version = "1.87"
+# Inherited from workspace - start
+version.workspace = true
+license.workspace = true
</file context>

version.workspace = true
license.workspace = true
authors.workspace = true
edition.workspace = true
publish.workspace = true
# Inherited from workspace - end

[[bin]]
name = "graphite"
Expand Down
Loading
Loading