Skip to content

Fix the SVG renderer not representing skewed raster images#4218

Merged
Keavon merged 1 commit into
masterfrom
fix-svg-raster-skew
Jun 9, 2026
Merged

Fix the SVG renderer not representing skewed raster images#4218
Keavon merged 1 commit into
masterfrom
fix-svg-raster-skew

Conversation

@Keavon

@Keavon Keavon commented Jun 9, 2026

Copy link
Copy Markdown
Member

Fixes #4199

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request simplifies the matrix transformation calculation in renderer.rs when rendering foreignObject tags. Instead of decomposing the transform into scale, angle, and translation, and then reconstructing it, the code now directly multiplies the transform by a scale matrix. There are no review comments, so I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@Keavon Keavon changed the title Fix the SVG renderer not skewing raster images to fit their bounds Fix the SVG renderer not representing skewed raster images Jun 9, 2026
@Keavon Keavon merged commit b4e04e6 into master Jun 9, 2026
11 checks passed
@Keavon Keavon deleted the fix-svg-raster-skew branch June 9, 2026 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Skewing images doesn't preview

1 participant