build: generate TypeScript ANTLR parser workspace#2572
Open
barry166 wants to merge 1 commit into
Open
Conversation
The client-side search validation work needs a generated TypeScript ANTLR workspace. This adds the workspace metadata, wires antlr-gen to emit TypeScript output alongside the existing Go parser, and keeps generated parser artifacts out of git while retaining a package-level smoke test for generated files. Constraint: Existing generation target keeps parser output generated rather than checked in Rejected: Commit generated TypeScript parser files | existing lib/gen ignore policy keeps generated parser output out of source control Confidence: high Scope-risk: narrow Directive: Keep FeatureSearch generated source out of git unless the repository changes its generated-code policy Tested: ANTLR_JAR=/tmp/webstatus-antlr/antlr-4.13.2-complete.jar make antlr-gen Tested: npm run test -w @webstatus.dev/feature-search-antlr Tested: npx prettier --check package.json package-lock.json lib/gen/antlrv4/ts-antlrv4/package.json Tested: git diff --check Not-tested: Full frontend test suite
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
antlr-gento emit TypeScript parser output alongside the existing Go parserRelated issue
Fixes #716
Verification
ANTLR_JAR=/tmp/webstatus-antlr/antlr-4.13.2-complete.jar make antlr-gennpm run test -w @webstatus.dev/feature-search-antlrnpx prettier --check package.json package-lock.json lib/gen/antlrv4/ts-antlrv4/package.jsongit diff --checkNotes
This PR was AI-assisted and manually reviewed before submission. The full frontend test suite was not run because this change only wires generated workspace metadata and the ANTLR generation target.