[Fixes #625] Error flushing memcached in restore#621
Merged
Conversation
The post-restore cleanup ran 'echo echo "flush_all" | nc ... memcached', which sends the literal string 'echo flush_all' to memcached. That is not a valid command, so memcached replies ERROR and the cache is never flushed. Drop the duplicated echo so the intended 'flush_all' command is sent.
etj
approved these changes
Jun 10, 2026
etj
changed the title
etj
changed the title
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The post-restore cleanup runs:
The doubled
echosends the literal stringecho flush_allto memcached, which isn't a valid command — memcached repliesERRORand the cache is never actually flushed. Stale entries can survive a restore until they expire.Fix
Drop the duplicated
echoso the intendedflush_allcommand is sent:Verification
sh -n restore.shpasses.echo echo "flush_all"emitsecho flush_all;echo "flush_all"emitsflush_all— confirming the byte stream sent to memcached.Note
This is independent of #618 (which modernizes
create_tile_layers→gwc createon line 76); this touches only the memcached flush on line 92.