feat(experimentation): warehouse connection verification UI#7678
feat(experimentation): warehouse connection verification UI#7678Zaimwa9 wants to merge 5 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@gemini-code-assist review |
Docker builds report
|
There was a problem hiding this comment.
Code Review
This pull request introduces the ability to test and verify Flagsmith warehouse connections from the frontend. It adds a new testWarehouseConnection mutation, updates the warehouse connection card to display event statistics and handle pending connection states, and implements a polling mechanism that queries the connection status every 30 seconds while pending. It also adds a utility to send a test custom event using a dedicated Flagsmith instance. The review feedback points out a critical issue where trackEvent will silently fail without an active identity; it suggests initializing the SDK with a dummy identity and a shorter event flushing interval, along with updating the corresponding unit tests.
Playwright Test Results (oss - depot-ubuntu-latest-arm-16)Details
Playwright Test Results (oss - depot-ubuntu-latest-16)Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-16)Details
|
Visual Regression19 screenshots compared. See report for details. |
docs/if required so people know about the feature.Changes
Frontend for verifying a Flagsmith-managed warehouse connection.
test_custom_eventvia a per-environment Flagsmith SDK instance (preventFetch+ emptydefaultFlags, so no customer flag config is fetched) and callsPOST .../test-warehouse-connection/to move the connection topending_connection.pending_connection, the warehouse tab polls the connectionsGETevery 30s; the backend flips it toconnectedonce an event lands.total_events_received/unique_events_countinto the stats panel; shows a "can take a few hours" message + "Verify now" while pending; hides the button once connected.flagsmithClientEventsAPIconfig per environment (events-ingestor URL).How did you test this code?