Clarify AND logic for multiple source filters in Custom Allocation Rules#37195
Merged
AustinLeaming merged 5 commits intoJun 3, 2026
Merged
Conversation
When a Custom Allocation Rule has multiple source filters in costs_to_allocate, they are combined with AND logic. This was not documented, causing confusion for customers using the API or Terraform provider. Ref: CLOUDS-8179
This comment has been minimized.
This comment has been minimized.
Contributor
Preview links (active after the
|
rtrieu
requested changes
Jun 2, 2026
rtrieu
left a comment
rtrieu
left a comment
Contributor
There was a problem hiding this comment.
minor suggestion to use active voice and remove redundancy
…rules.md Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com>
Per eng feedback (Safi Patel), clarify that while multiple source filters are AND'd together, the in/not in conditions within a single filter use OR logic (matching any of the listed values). Ref: CLOUDS-8179
safipatel
reviewed
Jun 3, 2026
safipatel
left a comment
safipatel
left a comment
Contributor
There was a problem hiding this comment.
looks good from an accuracy standpoint
safipatel
approved these changes
Jun 3, 2026
rtrieu
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a note to the Custom Allocation Rules documentation clarifying that when multiple source filters (
costs_to_allocate) are specified, they are combined with AND logic. A cost line must match all filter conditions to be selected for allocation.Why is this important?
This behavior is not documented anywhere — not in the public docs, API reference, or Terraform provider docs. A Tier 1 customer (CLOUDS-8179) raised this question, and we confirmed the AND behavior by reviewing:
dd-analytics/DailyProportionalAggregator.scala) — uses.forall()(Scala AND)k8s-resources) — three separate rules with AND'd filtersdd-source) — real rules with multiplecosts_to_allocateblocksdd-source) —repeated ArbitraryAllocationFilter costs_to_allocatePreview
The note appears in Step 1 - Define the source, right after the example, and reads:
Ref