Don't add empty headers on lambda completion#11551
Conversation
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
This comment has been minimized.
This comment has been minimized.
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
dougqh
left a comment
There was a problem hiding this comment.
I think a helper method that handles this might be a cleaner solution
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
andrea.marziali@datadoghq.com cancelled this merge request build |
purple4reina
left a comment
There was a problem hiding this comment.
+1 on Douglas's comment though
I wanted to avoid to add more to Strings but it's true that I can add something to LambdaHandler indeed |
|
/merge -c |
|
View all feedbacks in Devflow UI.
|
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
What Does This Do
Adding empty headers is not supported by okHttp. This PR add guards around possibly empty values.
Guards from errors like:
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issue/merge. You can also:/merge --commit-message "..."/merge -c/merge -f --reason "reason"; please use this judiciously, as some checks do not run at the PR-levelJira ticket: [PROJ-IDENT]