feat: implement default playback speed setting#1899
Closed
Ishant5436 wants to merge 1 commit into
Closed
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| showPlaybackStatusBadge={viewerId === data.owner.id} | ||
| isEditProcessing={isEditProcessing} | ||
| recordingStopped={recordingStopped} | ||
| defaultPlaybackSpeed={data.settings?.defaultPlaybackSpeed} |
Contributor
There was a problem hiding this comment.
defaultPlaybackSpeed
This reads only from data.settings (the raw video-level settings) and never falls back to data.orgSettings. Every other setting in this file is resolved via isDisabled, which correctly cascades videoSettings?.[key] ?? data.orgSettings?.[key] ?? false. If an admin configures defaultPlaybackSpeed only at the organization level (never per-video), viewers will always see 1× playback instead of the configured speed.
The expression should be data.settings?.defaultPlaybackSpeed ?? data.orgSettings?.defaultPlaybackSpeed.
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/web/app/s/[videoId]/Share.tsx
Line: 505
Comment:
**Org-level fallback missing for `defaultPlaybackSpeed`**
This reads only from `data.settings` (the raw video-level settings) and never falls back to `data.orgSettings`. Every other setting in this file is resolved via `isDisabled`, which correctly cascades `videoSettings?.[key] ?? data.orgSettings?.[key] ?? false`. If an admin configures `defaultPlaybackSpeed` only at the organization level (never per-video), viewers will always see 1× playback instead of the configured speed.
The expression should be `data.settings?.defaultPlaybackSpeed ?? data.orgSettings?.defaultPlaybackSpeed`.
How can I resolve this? If you propose a fix, please make it concise.
Member
|
Hey, thanks for submitting. This has already been added to Cap now - was a good coincidence! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, I implemented the default playback speed setting. I updated the effective video rules to cascade correctly and wired up the UI in the settings dialog. Tests are passing locally.