fix(frontend): show correct breadcrumb label for SDK evals by unfitcoder101 · Pull Request #4619 · Agenta-AI/agenta

unfitcoder101 · 2026-06-10T15:07:42Z

Summary

The typeMap in EvalRunDetails/components/Page.tsx was missing an
entry for the sdk evaluation type, causing SDK evals to always show
"Auto Evals" in breadcrumbs instead of "SDK Evals".

Added sdk: {label: "SDK Evals", kind: "sdk"} to fix the fallback.

Testing

Verified locally

Traced the bug to the missing sdk key in typeMap. Fix confirmed via grep.

Added or updated tests

N/A

QA follow-up

Verify breadcrumbs show "SDK Evals" when viewing an SDK evaluation run.

Demo

https://www.loom.com/share/ffc00463fcad4161abaad61dde0814f3

Checklist

I have included a video or screen recording for UI changes
I have signed the CLA

github-actions · 2026-06-10T15:07:54Z

✅ Thanks @unfitcoder101! This PR now meets the contribution requirements and has been reopened. A maintainer will review it soon.

unfitcoder101 · 2026-06-10T15:08:00Z

@mmabrouk reopened with full PR template. Setting up local environment for the demo video now.

coderabbitai · 2026-06-10T15:11:12Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 4090c6c8-7dff-4794-b253-15a6cd287bf7

📥 Commits

Reviewing files that changed from the base of the PR and between 0b197b1 and 3c2a226.

📒 Files selected for processing (1)

web/oss/src/components/EvalRunDetails/components/Page.tsx

🚧 Files skipped from review as they are similar to previous changes (1)

web/oss/src/components/EvalRunDetails/components/Page.tsx

📝 Walkthrough

Summary by CodeRabbit

New Features
- Added support for SDK evaluations: navigation now shows an "SDK Evals" breadcrumb and SDK-run listings are correctly identified when browsing evaluation runs, improving discoverability and context when exploring SDK-generated evaluations.

Walkthrough

Adds an "sdk" entry to the evaluation-type breadcrumb mapping so SDK evaluations render "SDK Evals" and include kind="custom" in breadcrumb link queries.

Changes

SDK Breadcrumb Configuration

Layer / File(s)	Summary
SDK evaluation breadcrumb mapping `web/oss/src/components/EvalRunDetails/components/Page.tsx`	Extends `evaluationTypeBreadcrumb` `typeMap` with an `"sdk"` entry mapping to label `"SDK Evals"` and URL query `kind: "custom"`.

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: fixing the breadcrumb label display for SDK evaluations.
Description check	✅ Passed	The description clearly explains the bug, the fix implemented, and includes verification steps and a demo video.
Linked Issues check	✅ Passed	The PR successfully addresses issue `#4549` by adding the missing 'sdk' entry to typeMap, ensuring SDK evals display 'SDK Evals' instead of 'Auto Evals' in breadcrumbs.
Out of Scope Changes check	✅ Passed	The single-line change only adds the required 'sdk' mapping to fix the identified issue, with no extraneous modifications present.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

unfitcoder101 · 2026-06-10T20:31:15Z

@mmabrouk I've updated the PR description with a demo video and full template. Please take a look when you get a chance.

vercel · 2026-06-10T20:32:11Z

@unfitcoder101 is attempting to deploy a commit to the agenta projects Team on Vercel.

A member of the Team first needs to authorize it.

coderabbitai

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

web/oss/src/components/EvalRunDetails/components/Page.tsx (1)
53-58: ⚠️ Potential issue | 🔴 Critical

Fix SDK breadcrumb kind to match EvaluationsView (custom not sdk)

EvaluationsView drives its tabs/filter strictly from the kind query param with tab keys all | auto | human | online | custom (SDK Evals uses key: "custom"). The SDK breadcrumb currently links to /evaluations?kind=sdk, so the page won’t select the correct tab and will set an invalid evaluation kind.
Proposed fix
-            sdk: {label: "SDK Evals", kind: "sdk"},
+            sdk: {label: "SDK Evals", kind: "custom"},

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 0b8f543c-c705-42e6-8d7c-8da19c96d92f

📥 Commits

Reviewing files that changed from the base of the PR and between 787ed8b and 1d5adbd.

📒 Files selected for processing (1)

web/oss/src/components/EvalRunDetails/components/Page.tsx

mmabrouk · 2026-06-10T20:40:30Z

Thanks @unfitcoder101 for the video. You are supposed however to demo the fix not show the code :)

How can we know if the fix works if you did not try it?

mmabrouk

see prev comment

unfitcoder101 · 2026-06-10T21:00:50Z

@mmabrouk you're right, my apologies. I'm setting up the local environment now to record an actual UI demo. Will update within a few hours.

unfitcoder101 · 2026-06-11T06:58:03Z

@mmabrouk Updated with a proper UI demo showing the breadcrumb correctly displaying "SDK Evals" when navigating to the SDK Evals tab in the local environment. https://www.loom.com/share/ffc00463fcad4161abaad61dde0814f3

mmabrouk

Thanks @unfitcoder101 Looks great!

mmabrouk · 2026-06-11T17:19:26Z

@all-contributors please add @unfitcoder101 for bug fix

allcontributors · 2026-06-11T17:19:45Z

@mmabrouk

I've put up a pull request to add @unfitcoder101! 🎉

unfitcoder101 · 2026-06-11T18:57:30Z

Thanks @mmabrouk! Happy to contribute. Looking forward to picking up more issues — let me know if there's anything specific the team needs help with.

coderabbitai

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

web/oss/src/components/EvalRunDetails/components/Page.tsx (1)
66-72: 🎯 Functional Correctness | 🟠 Major | ⚡ Quick win

Use kind=custom for SDK breadcrumb links to match /evaluations filter contract.

Line 66 sets kind: "sdk", but the downstream evaluations tab/filter contract uses custom for “SDK Evals”. This sends users to a mismatched query state when clicking the breadcrumb.
Suggested fix
 const evaluationTypeBreadcrumb = useMemo(() => {
     const typeMap: Record<string, {label: string; kind: string}> = {
         auto: {label: "Auto Evals", kind: "auto"},
         human: {label: "Human Evals", kind: "human"},
         online: {label: "Live Evals", kind: "online"},
-        sdk: {label: "SDK Evals", kind: "sdk"},
+        sdk: {label: "SDK Evals", kind: "custom"},
     }

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 562859fb-671d-45c7-ac8d-4e5ada98faac

📥 Commits

Reviewing files that changed from the base of the PR and between 1d5adbd and 0b197b1.

📒 Files selected for processing (1)

web/oss/src/components/EvalRunDetails/components/Page.tsx

… evaluations page contract

unfitcoder101 · 2026-06-12T21:58:48Z

@coderabbitai good catch — verified locally. The entire EvaluationRunsTablePOC codebase uses kind="custom" for SDK evals. Pushed a follow-up commit changing the SDK breadcrumb to use kind="custom" so the link routes correctly.

@mmabrouk PR is ready for re-review whenever you have a moment. Thanks!

coderabbitai · 2026-06-12T21:59:23Z

Tip

For best results, initiate chat on the files or code changes.

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Check the current state of the Page.tsx file and the typeMap
rg -n "typeMap|sdk|kind" web/oss/src/components/EvalRunDetails/components/Page.tsx -A2 -B2

Length of output: 1092

@unfitcoder101 Thanks for the follow-up! Confirmed the fix looks correct in the current state of the file:

sdk: {label: "SDK Evals", kind: "custom"},

The breadcrumb will now display "SDK Evals" and route to evaluations?kind=custom, which aligns with how the EvaluationRunsTablePOC handles SDK evaluation runs. Everything looks good! 🐇

unfitcoder101 · 2026-06-12T22:01:20Z

Thanks @coderabbitai for the confirmation! @mmabrouk - all checks should be green now, ready to merge whenever you have a moment. Looking forward to picking up the next task.

coderabbitai · 2026-06-12T22:01:34Z

Tip

For best results, initiate chat on the files or code changes.

@unfitcoder101 You're welcome! The fix is clean and well-verified — great work on the contribution. Hope the merge goes smoothly and looking forward to seeing your future contributions! 🐇 ✨

fix(frontend): show correct breadcrumb label for SDK evals

15d65ec

github-actions Bot added the incomplete-pr PR is missing required template sections or a demo recording label Jun 10, 2026

github-actions Bot closed this Jun 10, 2026

unfitcoder101 deleted the fix/sdk-eval-breadcrumb-label branch June 10, 2026 20:24

unfitcoder101 restored the fix/sdk-eval-breadcrumb-label branch June 10, 2026 20:27

github-actions Bot removed the incomplete-pr PR is missing required template sections or a demo recording label Jun 10, 2026

github-actions Bot reopened this Jun 10, 2026

Merge branch 'main' into fix/sdk-eval-breadcrumb-label

1d5adbd

dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jun 10, 2026

coderabbitai Bot reviewed Jun 10, 2026

View reviewed changes

mmabrouk requested changes Jun 10, 2026

View reviewed changes

mmabrouk approved these changes Jun 11, 2026

View reviewed changes

dosubot Bot added the lgtm This PR has been approved by a maintainer label Jun 11, 2026

allcontributors Bot mentioned this pull request Jun 11, 2026

docs: add unfitcoder101 as a contributor for bug #4651

Merged

Merge branch 'main' into fix/sdk-eval-breadcrumb-label

0b197b1

coderabbitai Bot reviewed Jun 12, 2026

View reviewed changes

fix(frontend): use kind=custom for SDK evals breadcrumb link to match…

3c2a226

… evaluations page contract

Conversation

unfitcoder101 commented Jun 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Testing

Verified locally

Added or updated tests

QA follow-up

Demo

Checklist

Uh oh!

github-actions Bot commented Jun 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

unfitcoder101 commented Jun 10, 2026

Uh oh!

coderabbitai Bot commented Jun 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Walkthrough

Changes

Uh oh!

unfitcoder101 commented Jun 10, 2026

Uh oh!

vercel Bot commented Jun 10, 2026

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

mmabrouk commented Jun 10, 2026

Uh oh!

mmabrouk left a comment

Choose a reason for hiding this comment

Uh oh!

unfitcoder101 commented Jun 10, 2026

Uh oh!

unfitcoder101 commented Jun 11, 2026

Uh oh!

mmabrouk left a comment

Choose a reason for hiding this comment

Uh oh!

mmabrouk commented Jun 11, 2026

Uh oh!

allcontributors Bot commented Jun 11, 2026

Uh oh!

unfitcoder101 commented Jun 11, 2026

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

unfitcoder101 commented Jun 12, 2026

Uh oh!

coderabbitai Bot commented Jun 12, 2026

Uh oh!

unfitcoder101 commented Jun 12, 2026

Uh oh!

coderabbitai Bot commented Jun 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

unfitcoder101 commented Jun 10, 2026 •

edited

Loading

github-actions Bot commented Jun 10, 2026 •

edited

Loading

coderabbitai Bot commented Jun 10, 2026 •

edited

Loading