Replace !! operators with idiomatic Kotlin null handling (#57076)#57076
Closed
Abbondanzo wants to merge 1 commit into
Closed
Replace !! operators with idiomatic Kotlin null handling (#57076)#57076Abbondanzo wants to merge 1 commit into
Abbondanzo wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@Abbondanzo has exported this pull request. If you are a Meta employee, you can view the originating Diff in D107525522. |
cortinico
approved these changes
Jun 4, 2026
cortinico
left a comment
cortinico
left a comment
Contributor
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
Summary: Replace all non-null assertion operators (`!!`) with idiomatic Kotlin alternatives following code review feedback. Use `checkNotNull()` for validation, safe call operators (`?.`) with early returns, and local variables to eliminate repeated null assertions. Also adopt Kotlin stdlib helpers like `isNullOrEmpty()` and AndroidX KTX extensions (`isNotEmpty()`, `isEmpty()`, `toDrawable()`) for cleaner, more type-safe code. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D107525522
meta-codesync
Bot
changed the title
Abbondanzo
force-pushed
the
export-D107525522
branch
from
43c0b3f to
5b8af55
Compare
|
This pull request has been merged in 3c4f571. |
Collaborator
|
This pull request was successfully merged by @Abbondanzo in 3c4f571 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Replace all non-null assertion operators (
!!) with idiomatic Kotlin alternatives following code review feedback.Use
checkNotNull()for validation, safe call operators (?.) with early returns, and local variables to eliminate repeated null assertions. Also adopt Kotlin stdlib helpers likeisNullOrEmpty()and AndroidX KTX extensions (isNotEmpty(),isEmpty(),toDrawable()) for cleaner, more type-safe code.Changelog: [Internal]
Reviewed By: cortinico
Differential Revision: D107525522