changed: hessian=true default to dense ForwardDiff for MovingHorizonEstimation#369
Closed
franckgaga wants to merge 1 commit into
Closed
changed: hessian=true default to dense ForwardDiff for MovingHorizonEstimation#369franckgaga wants to merge 1 commit into
hessian=true default to dense ForwardDiff for MovingHorizonEstimation#369franckgaga wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #369 +/- ##
=======================================
Coverage 98.57% 98.57%
=======================================
Files 27 27
Lines 5468 5468
=======================================
Hits 5390 5390
Misses 78 78 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
hessian=true to dense ForwardDiff for MovingHorizonEstimationhessian=true default to dense ForwardDiff for MovingHorizonEstimation
Benchmark Results (Julia v1)Time benchmarks
Memory benchmarks
|
Member
Author
|
Nope not worth it, let's close this PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following discussion at #368, I'm testing if the performances of dense
ForwardDiff.jlbackend is a more appropriate default whenhessian=truefor theMovingHorizonEstimator. Let's benchmark this.